guan404ming commented on code in PR #73555:
URL: https://github.com/apache/airflow/pull/73555#discussion_r4111735588
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/gantt.py:
##########
@@ -95,14 +107,24 @@ def get_gantt_data(
combined = union_all(current_tis, history_tis).subquery()
query = select(combined).order_by(combined.c.task_id,
combined.c.try_number)
+ # Rebind the filters to the union subquery columns so they apply to both
TI and TIH rows.
Review Comment:
I think we could widen `RangeFilter.attribute` to `ColumnElement` instead of
`# type: ignore` here?
##########
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx:
##########
@@ -298,7 +298,7 @@ export const PanelButtons = ({
{dagView !== "graph" && (
<Flex justifyContent="space-between" mt={2}>
- <GridFilters />
+ <GridFilters showGanttDateFilters={dagView === "gantt"} />
Review Comment:
Switching to Grid hides these pills but leaves the params in the URL. I
think we could clear them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
