KarthikMohankumar opened a new pull request, #73760:
URL: https://github.com/apache/airflow/pull/73760
`snowflake/triggers/snowflake_trigger.py` was on the `OVERLOOKED_TESTS`
allowlist in `test_project_structure.py`, even though it already had tests.
They were named `test_snowflake.py`, so the structure check could not match
them to the module.
This PR:
- renames `tests/unit/snowflake/triggers/test_snowflake.py` to
`test_snowflake_trigger.py`
- adds two tests for `SnowflakeSqlApiTrigger.run()` with several query ids,
which had no coverage before:
- a query that is still `running` is re-polled after `poll_interval`
before the next query id is checked, and success is reported once every id has
finished
- the first query that returns `error` ends the run with that event, and
later query ids are never polled
- removes the entry from `OVERLOOKED_TESTS`
Tests only. No change to runtime behaviour.
related: #35442
Checks run locally:
- `uv run --project providers/snowflake pytest
tests/unit/snowflake/triggers/test_snowflake_trigger.py`: 13 passed
- the two new tests fail if the trigger stops returning after an error
event, or stops sleeping for `poll_interval`, both checked by temporarily
modifying the trigger
-
`test_project_structure.py::TestProjectStructure::test_providers_modules_should_have_tests`:
passed
- `prek run --stage pre-commit` on the changed files: all applicable hooks
passed, including `check-tests-in-the-right-folders` and `mypy-airflow-core`.
`ast-grep` was skipped locally because it could not download its Node runtime.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5.5)
Generated-by: Claude Code (Opus 5.5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
