codechrl opened a new pull request, #73766:
URL: https://github.com/apache/airflow/pull/73766

   `[scheduler] task_instance_heartbeat_sec` has no effect in Airflow 3. Every 
task runs under the task supervisor, which takes its heartbeat interval from 
`[workers] min_heartbeat_interval`. Nothing reads 
`task_instance_heartbeat_sec`. The configuration reference still describes it 
as "The frequency (in seconds) at which the LocalTaskJob should send heartbeat 
signals to the scheduler". The "Reproducing task instance heartbeat timeouts 
locally" how-to sets it to slow heartbeats down.
   
   The option is removed from `config.yml`. The how-to now sets 
`AIRFLOW__WORKERS__MIN_HEARTBEAT_INTERVAL` instead. `airflow config lint` and 
`airflowctl config lint` report the option as removed and point at 
`min_heartbeat_interval`. Both commands reported the Airflow 2 name 
`local_task_job_heartbeat_sec` as renamed to `task_instance_heartbeat_sec`. 
They now report it as removed too. `airflow config update --fix 
--all-recommendations` rewrote the Airflow 2 name as 
`task_instance_heartbeat_sec`. It now removes both names.
   
   The template default has to go with the lint rule. While `config.yml` 
defines the option, `conf.has_option` is true on every install. The removal 
rule would then flag every install.
   
   The new parametrized lint tests in `airflow-core` and `airflow-ctl` cover 
both names. Their assertions fail without the source change and pass with it.
   
   related: #58307
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (Claude Code, Opus 5.5)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to