rjgoyln opened a new pull request, #73782:
URL: https://github.com/apache/airflow/pull/73782

   Continues #73204.
   
   ## Summary
   
   Both suspended-provider filters in the `provider.yaml` check are 
nested-`for` comprehensions, so they keep an entry when **any** suspended 
provider fails to match it rather than when none do. Suspend two providers at 
once and each one's doc URLs survive, because the other suspended provider is 
absent from them — the check then reports them as missing from `provider.yaml` 
and fails on docs it was meant to ignore.
   
   The error filter has the same shape, and additionally repeats every 
unrelated error once per suspended provider.
   
   The cross product is accidentally correct for a single suspended provider, 
the only configuration the check has ever run with. With none suspended it 
emptied the set instead — what the two guards were covering for.
   
   ## Change
   
   - Match every suspended provider against an entry rather than any one of 
them.
   - Move both filters to `scripts/in_container/provider_suspension.py` so they 
can be tested.
   - Cover zero, one and several suspended providers in the tests.
   
   The filters moved because the check script refuses to be imported as a 
module; behaviour for a single suspended provider is unchanged.
   
   ## Compatibility
   
   Matching stays substring-based: suspending `apache-airflow-providers-git` 
would also strip the `apache-airflow-providers-github` docs, as it does today. 
Narrowing it to the `/docs/<package-name>/` prefix is a separate change.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5)
   
   Generated-by: Claude Code (Opus 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to