rjgoyln opened a new pull request, #73785:
URL: https://github.com/apache/airflow/pull/73785

   Continues #73170.
   
   ## Summary
   
   `update-local-yml-file` printed a red error and exited zero when `breeze 
setup synchronize-local-mounts` failed, so the hook reported green on a failed 
synchronization and left the generated volume list in 
`scripts/ci/docker_compose/local.yml` stale.
   
   - Exit with the command's return code, as the other hooks in 
`scripts/ci/prek/` do.
   - Cover that exit code with a test running the real script against a stubbed 
`breeze`.
   
   Two guards already narrow the silent path: prek's own "files were modified 
by this hook" check catches a synchronization that succeeds and rewrites the 
file, and `initialize_breeze_prek` exits 1 when `breeze` is not on `PATH`. What 
is left is a breeze run that fails — most likely a broken 
`docker_command_utils.py`, which both triggers this hook and supplies the mount 
list the command reads.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5)
   
   Generated-by: Claude Code (Opus 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to