rjgoyln commented on code in PR #73756:
URL: https://github.com/apache/airflow/pull/73756#discussion_r4115160891
##########
providers/amazon/tests/unit/amazon/aws/hooks/test_s3.py:
##########
@@ -2052,6 +2052,20 @@ def get_logs_string(call_args_list):
assert "local file last modified" in logs_string
assert "Downloaded dag_04.py to" in logs_string
+ @pytest.mark.parametrize("s3_prefix", ["dags", "project/dags"])
+ @pytest.mark.parametrize("sibling_suffix", ["_archive/old.py", "_old.py",
""])
Review Comment:
The "" case isn't really a sibling key — it's a key equal to the prefix, and
it fails differently without the fix (NotADirectoryError rather than the
ValueError from relative_to). Giving it an explicit id would make that
distinction clearer in CI failures.
```suggestion
@pytest.mark.parametrize(
"sibling_suffix", ["_archive/old.py", "_old.py", pytest.param("",
id="key_equals_prefix")]
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
