henry3260 commented on code in PR #72862:
URL: https://github.com/apache/airflow/pull/72862#discussion_r4115656785
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/assets.py:
##########
@@ -217,6 +218,7 @@ def next_run_assets(
.group_by(AssetModel.id, AssetModel.uri, AssetModel.name,
AssetActive.name)
.order_by(AssetModel.uri)
)
+ query = readable_assets_filter.to_orm(query)
Review Comment:
> This drops unreadable rows, while #72864 keeps redacted expression slots
to preserve the schedule shape. `AssetSchedule.tsx` uses `nextRunEvents.length`
for the count, so a caller who can read 1 of 3 assets will see a one-asset
trigger, and potentially "2 of 2" for a Dag actually waiting on 3. If we keep
dropping rows, I think the PR body should note that these counts are now
caller-scoped and may need a UI follow-up to reconcile them with the redacted
expression.
Thank you for pointing this out. I will open a issue to track this UI follow
up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
