Clara0619 commented on code in PR #73317:
URL: https://github.com/apache/airflow/pull/73317#discussion_r4118997017
##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -730,6 +736,7 @@ def _create_arg_for_non_primitive_type(
arg_type=self._python_type_from_string(annotation),
arg_action=argparse.BooleanOptionalAction if annotation is
bool else None, # type: ignore
arg_help=f"{field} for {parameter_key} operation",
+ arg_required=field_type.is_required() and
cli_defaults[field] is None,
Review Comment:
Updated the required-field check to exclude nullable fields as suggested.
The full airflow-ctl test suite passes locally (400 passed). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]