potiuk commented on PR #73801: URL: https://github.com/apache/airflow/pull/73801#issuecomment-5865739188
Thanks for this, it's a nice check to have. I pushed one small fixup and rebased onto `main`: - **9f92f60fcd — placeholder keys are compared the way Airflow resolves them.** At runtime, `_ensure_prefix_for_placeholders` (`airflow-core/src/airflow/providers_manager.py`) treats a bare placeholder key such as `keyfile_dict` and the prefixed `extra__<conn_type>__keyfile_dict` as the same field, on both the provider.yaml path and the hook path. The check compared keys exactly as written, so a provider that used the bare form on one side and the prefixed form on the other would get a "placeholders differ" failure even though the connection form looks identical on every Airflow version. No provider does this today, so it was latent, but the check now normalises keys the same way before comparing. There's a matching test case (`bare-and-prefixed-placeholder-keys-are-equal`). - **Rebased onto `main`** to pick up the fix for the flaky test that failed on the previous run. I'll approve and merge once CI is green. --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
