ashb commented on code in PR #73625: URL: https://github.com/apache/airflow/pull/73625#discussion_r4121632129
########## task-sdk/src/airflow/sdk/serde/serializers/iceberg.py: ########## @@ -24,6 +24,9 @@ serializers = ["pyiceberg.table.Table"] deserializers = serializers stringifiers = serializers +# Deserializing loads the catalog from the serialized properties, so the class must be +# listed in ``[core] allowed_deserialization_classes`` rather than allowed implicitly. +allow_by_default = False Review Comment: Nit: this is a constant, so should be treated as such? ```suggestion ALLOW_BY_DEFAULT = False ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
