uranusjr commented on code in PR #70805:
URL: https://github.com/apache/airflow/pull/70805#discussion_r4122131825
##########
task-sdk/src/airflow/sdk/coordinators/_bundle_metadata.py:
##########
@@ -96,6 +103,25 @@ def _sorted_children(directory: pathlib.Path) ->
list[pathlib.Path]:
return []
+def convert_configured_roots(
+ value: _UnsetArtifactRoots
+ | None
+ | os.PathLike[str]
+ | pathlib.Path
+ | list[os.PathLike[str] | pathlib.Path],
+) -> list[pathlib.Path]:
+ """Normalize configured roots while rejecting explicitly empty values."""
+ if isinstance(value, _UnsetArtifactRoots):
+ return []
+ roots = convert_roots(value)
Review Comment:
This converts `""` into `[Path(".")]` (standard pathlib normalisation) so
the `not roots` check will not work correctly. I’m not sure if it’s intended
(it’s not covered by tests) but it might be a footgun if we do `get(...,
fallback="")` or something like `get(...) or ""`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
