amoghrajesh commented on code in PR #72100:
URL: https://github.com/apache/airflow/pull/72100#discussion_r4122623644
##########
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx:
##########
@@ -86,25 +87,29 @@ const ClearTaskInstanceDialog = (props: Props) => {
const [clearTaskInstanceDefaultOptions] =
useClearTaskInstanceDefaultOptions();
const [preventRunningTaskDefault] = useClearPreventRunningTaskDefault();
+ const [keepTaskStateDefault] = useClearKeepTaskStateDefault();
const [selectedOptions, setSelectedOptions] =
useState<Array<string>>(clearTaskInstanceDefaultOptions);
const onlyFailed = selectedOptions.includes("onlyFailed");
const past = selectedOptions.includes("past");
const future = selectedOptions.includes("future");
const upstream = selectedOptions.includes("upstream");
const downstream = selectedOptions.includes("downstream");
+ const [keepTaskState, setKeepTaskState] = useState(keepTaskStateDefault);
const [preventRunningTask, setPreventRunningTask] =
useState(preventRunningTaskDefault);
const [note, setNote] = useState<string | null>(taskInstance?.note ?? null);
useEffect(() => {
if (openDialog) {
setNote(taskInstance?.note ?? null);
+ setKeepTaskState(keepTaskStateDefault);
}
- }, [openDialog, taskInstance?.note]);
+ }, [openDialog, taskInstance?.note, keepTaskStateDefault]);
Review Comment:
Split the effect so `keepTaskState` only resets on dialog open, not on
background note changes. Also added a test that proves the checkbox honors the
stored default and the confirm request carries `keep_task_state` correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
