zach-overflow commented on code in PR #73116:
URL: https://github.com/apache/airflow/pull/73116#discussion_r4123132182
##########
shared/logging/src/airflow_shared/logging/structlog.py:
##########
@@ -420,22 +420,16 @@ def structlog_processors(
# structlog to ignore.
import contextlib
+ import importlib
import click
suppress: tuple[ModuleType, ...] = (click, contextlib)
- try:
- import httpcore
-
- suppress = (*suppress, httpcore)
- except ImportError:
- pass
- try:
- import httpx
-
- suppress = (*suppress, httpx)
- except ImportError:
- pass
+ # airflow-core is still on httpx while the Task SDK is on httpx2, so
either (or both) may
+ # be installed; tracked at https://github.com/apache/airflow/issues/70522
+ for module_name in ("httpcore", "httpcore2", "httpx", "httpx2"):
Review Comment:
added 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
