fat-catTW commented on code in PR #73169: URL: https://github.com/apache/airflow/pull/73169#discussion_r4140491457
########## providers/amazon/tests/unit/amazon/aws/executors/batch/test_batch_executor_config.py: ########## Review Comment: I originally moved it because batch_executor_config.py did not have its own dedicated test file, so I thought test_batch_executor_config.py would be the appropriate location and could be removed from OVERLOOKED_TESTS. But I agree that moving the existing class created an unnecessary diff. I moved the useful new coverage back into the existing TestBatchExecutorConfig in test_batch_executor.py, removed the new file, and added test_batch_executor_config.py back to OVERLOOKED_TESTS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
