kaxil commented on code in PR #73912: URL: https://github.com/apache/airflow/pull/73912#discussion_r4146099657
########## scripts/in_container/run_agent_framework_tests.sh: ########## @@ -0,0 +1,89 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Runs the common.ai adapter tests for agent frameworks that cannot join the workspace lock. +# +# Strands Agents caps mcp, and Google ADK caps opentelemetry and websockets, below the versions +# uv.lock resolves, so their adapter tests are skipped everywhere else in CI. This installs one +# framework into the CI image and runs the tests of the framework-neutral tools and their adapters; +# the other framework's tests skip themselves. One framework per invocation, so a bad release of +# one cannot mask the other. +# +# By default every package already in the image is held at its installed version with uv's +# --override, so the framework is tested against the same dependencies as the rest of Airflow and +# its caps on them are overridden. With --framework-pins the framework's own requirements win +# instead, which is the environment a user who installs it gets. +# +# The newest framework release older than the repository's uv exclude-newer window is installed. +set -euo pipefail + +TEST_PATH="providers/common/ai/tests/unit/common/ai/tools" + +framework="${1:-}" +case "${framework}" in + strands-agents) import_check="import strands" ;; + google-adk) import_check="import google.adk" ;; + *) + echo "Usage: $0 <strands-agents|google-adk> [--framework-pins]" >&2 + exit 1 + ;; +esac +FRAMEWORKS=("${framework}") Review Comment: Done in 6561a2a: the array is gone and both install calls use `${framework}` directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
