Andrushika opened a new pull request, #73955:
URL: https://github.com/apache/airflow/pull/73955

   ## Why
   
   Since #73836, `breeze down` no longer calls `docker compose down`. It lists 
the containers, volumes and networks of the Breeze projects for the current 
checkout, including containers that are still running. Then it runs four steps 
in order:
   
   1. `docker container stop`
   2. `docker container rm`
   3. `docker volume rm`
   4. `docker network rm`
   
   If one step fails, `breeze down` exits with a traceback and skips the rest. 
A running `breeze start-airflow` container makes it fail in two ways:
   
   - The container was started with `docker compose run --rm`, so it deletes 
itself as soon as step 1 stops it. Step 2 then gets "No such container". The 
container is gone, but steps 3 and 4 never run, so the volumes and network stay.
   - The container can need more than the 10 second stop timeout to exit. Then 
step 1 itself fails, and the container may still be running.
   
   On main I got one of the two in 5 of 5 runs against a running `breeze 
start-airflow` container (macOS, Docker Desktop 28.4).
   
   ## What
   
   Step 1 is now best effort. `breeze down` waits for the containers to exit 
and removes only the ones that still exist. The removal uses `--force`, so a 
container that is still running after the wait is killed and not left behind.
   
   related: #73836
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Fable 5.1)
   
   Generated-by: Claude Code (Fable 5.1) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to