henry3260 opened a new issue, #73954:
URL: https://github.com/apache/airflow/issues/73954
`go-sdk/pkg/execution/genmodels/models.gen.go` is generated from the
supervisor wire-schema
snapshot at `task-sdk/src/airflow/sdk/execution_time/schema/schema.json`,
and it is behind it.
The snapshot last moved in #73224 and #73027; the models were last
regenerated in #73531,
before both. Running `just generate-models` on current `main` adds two
fields:
```go
MultiTeam bool `msgpack:"multi_team,omitempty"`
RetryReason interface{} `msgpack:"retry_reason,omitempty"`
```
Nothing failed, because msgpack drops a field the struct does not declare —
so the supervisor
sends these and the Go SDK cannot see them.
Nothing regenerates or verifies the file, which is why the drift went
unnoticed across two PRs.
The Go SDK's Dag specs got a check for exactly this in #73936
(`scripts/ci/prek/check_go_sdk_spec_drift.py`): regenerate, then ask Git
whether the committed
file changed.
### To do
- [ ] Regenerate `models.gen.go` and commit it.
- [ ] Extend the drift check to cover it, so a snapshot change that never
reaches Go fails CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
