Andrushika opened a new pull request, #73964:
URL: https://github.com/apache/airflow/pull/73964

   ## Why
   
   Breeze mounts a compose volume on `/root/.cache` of the airflow container. 
It holds the uv, pip and node caches. #48740 added it, together with `breeze 
down --cleanup-build-cache` and a step in `breeze doctor` to remove it. The 
docs say that `down` does not delete build caches unless an explicit 
cache-cleanup flag is passed.
   
   The code does the opposite:
   
   - The flag and `breeze doctor` run `docker volume rm --force 
airflow-cache-volume`. Docker Compose prefixes the volume with the project 
name, so the real volume is for example `breeze_airflow-cache-volume`. No 
volume has the bare name, and `--force` hides the miss. Both lines are 
unchanged since #48740.
   - A plain `breeze down` removes all volumes of the project, so it removes 
the cache every time.
   
   So on main `breeze down` deletes the cache, and `breeze down -p -b` keeps it.
   
   ## What
   
   `breeze down` now recognises the volume by its `com.docker.compose.volume` 
label and keeps it unless `--cleanup-build-cache` is passed. The flag also 
works together with `--preserve-volumes`. `breeze doctor` removes the volume 
after its confirmation. The cache of a deleted worktree is still removed 
without the flag.
   
   This changes what a plain `breeze down` removes. Each project keeps about 
100 MB after it, because the image already ships 98 MB in `/root/.cache`. Happy 
to keep only the flag fix if that is not wanted.
   
   related: #48740, #73836
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Fable 5.1)
   
   Generated-by: Claude Code (Fable 5.1) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to