FrankYang0529 opened a new pull request, #74003: URL: https://github.com/apache/airflow/pull/74003
Implement [Go SDK: Add airflow.TriggerDagRun](https://github.com/orgs/apache/projects/499/views/7?pane=issue&itemId=248987124). - `airflow.TriggerDagRun(spec)` returns a value that `dag.Task` takes in place of a Go function. A task built from that value has no Go function to take a `task_id` from, so `dag.Task` panics unless a `TaskSpec` sets `TaskID`. - Each field of `TriggerDagRunSpec` sets one parameter of `TriggerDagRunOperator`. A field left at its zero value leaves that parameter at its Python default: - `PokeInterval` and `Deferrable` are pointers, as in the generated `TaskSpec`, so that 0 and false can be set. - A nil `FailedStates` keeps the Python default, so a task that waits fails when the new Dag run fails. With `FailedStates` set to an empty list, such as `[]string{}`, no state fails the task. Python treats `failed_states=[]` the same way. - `dag.Task` checks the spec when it adds the task and panics in these cases, with a message that names the task and the Dag: - `DagID` is empty. - `PokeInterval` is negative or is not a whole number of seconds. - `AllowedStates` or `FailedStates` holds a value that is not a Dag run state. - `Conf` does not marshal to JSON. - `dag.Task` stores a deep copy of the spec, so changes that the caller makes afterwards do not reach the task. - Three acceptance criteria wait for later items on the board, because those criteria need does not exist yet. Serializing the task as `TriggerDagRunOperator` with the task's options, and keeping the task off the Go SDK's queue, belong to [Go SDK: Serialize a native Dag to Dag JSON](https://github.com/orgs/apache/projects/499/views/7?pane=issue&itemId=248987212). Ordering the task with `Before` and `After` belongs to [Go SDK: Add airflow.Node with Before, After, and Label](https://github.com/orgs/apache/projects/499/views/7?pane=issue&itemId=248987142). <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. For user-facing UI changes, please attach before/after screenshots (or a short screen recording) so reviewers can assess the visual impact. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [X] Yes - Claude Code <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
