mik-laj commented on a change in pull request #7091: [AIRFLOW-6489] Separate 
integrations
URL: https://github.com/apache/airflow/pull/7091#discussion_r365755489
 
 

 ##########
 File path: scripts/ci/in_container/_in_container_utils.sh
 ##########
 @@ -195,4 +195,5 @@ EOF
 
 function stop_output_heartbeat() {
     kill "${HEARTBEAT_PID}"
+    wait "${HEARTBEAT_PID}" || true 2> /dev/null
 
 Review comment:
   What do you think to start using `jobs/fg/bg/kill %1` here? Running scripts 
this way is a bit hacky to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to