xBis7 opened a new pull request, #74046:
URL: https://github.com/apache/airflow/pull/74046
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Issue
When using OpenTelemetry, every metric exported from the task-sdk while a
task is running (including custom user-defined metrics) is broken. Note here
that this issue doesn't exist for StatsD.
For every task, a new task runner is created along with a new
`MeterProvider`. As a result, each series of metrics is treated as new and
unique and values don't accumulate.
For example, if we had 5 successful tasks, we would expect to see a value 5
for the counter `airflow_ti_successes_total`. Instead we end up with a series
of 1, 1, 1, 1, 1.
## Solution
The solution is to maintain all the call sites exactly as they are but use a
new type of logger which keeps everything in memory instead of sending them to
a collector. All the accumulated metrics are forwarded to the supervisor and
that in turn sends them as a batch to the API server over an endpoint. The API
server is a long-lived process with its own `MeterProvider` which exports all
the individual task metrics. This solves the accumulation issue while also
allowing for the usage of user-defined metrics.
## Testing
I've added an integration test that reads the metrics directly from the
otel-collector and checks the value of task metrics to make sure that a counter
is increased.
I've also added unit tests for the in-memory accumulating logic as well as
the forwarding.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Claude-code Fable 5.1 xhigh
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
