kaxil commented on PR #71286:
URL: https://github.com/apache/airflow/pull/71286#issuecomment-5942544037

   Is a 226-line reimplementation of CPython's traceback formatting, plus 633 
lines of tests, the right size for this TODO? The new branch only runs for 
records from the TriggerRunner itself, since records with a `trigger_id` go to 
the task log, and the Elasticsearch handler already renders the same structlog 
payload with `_format_error_detail` in about 24 lines. Moving that into 
`shared/logging` would close the TODO with far less to maintain. Is there a 
case it doesn't cover that needs the full reimplementation? Converting to draft 
until that's settled.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to