kaxil commented on PR #72245:
URL: https://github.com/apache/airflow/pull/72245#issuecomment-5942556525

   Closing this. `on_kill` runs outside the trigger's `async with self.hook`, 
and the hook's `__aexit__` sets `_session = None`, so replacing 
`sync_to_async(self.hook.cancel_run)` with `await 
self.hook.a_cancel_run(run_id)` makes cancellation use a `None` session. There 
are no tests. On #71525 the crash was confirmed to affect only 3.0.x and be 
fixed in core from 3.1.0, and #71840 is the further-along PR for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to