pierrejeambrun opened a new pull request, #74079: URL: https://github.com/apache/airflow/pull/74079
Stack: #74034, #74040, #74041, #74042, #74035, **this PR** - **Depends on https://github.com/apache/airflow/pull/74035 get merged first** (only the last commit is new here). ## Why `SerializedTaskGroup.topological_sort`'s docstring says `DAG.check_cycle` is what keeps a cyclic Dag from ever reaching it. That was true, but only for a Python-authored Dag — a Lang-SDK Dag has no Python `DAG` object to call `check_cycle` on, so the comment overstated the actual guarantee for the other authoring path. #74035 closes that gap: the Dag processor now runs `DagSerialization.validate_serialized_dag` on every Dag a Lang-SDK runtime returns, rejecting one with a cycle as an import error before it is ever stored (both this and `DAG.check_cycle` are backed by the shared `detect_cycle` from #74034). The comment should name both guards. ## What One docstring update, no behavior change. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 4.7) Generated-by: Claude Code (Opus 4.7) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
