xlsongc commented on code in PR #73926:
URL: https://github.com/apache/airflow/pull/73926#discussion_r4165510538
##########
providers/common/ai/tests/unit/common/ai/operators/test_document_loader.py:
##########
@@ -422,6 +432,54 @@ def
test_docx_missing_raises_optional_feature_exception(self, tmp_path):
with pytest.raises(AirflowOptionalProviderFeatureException):
op.execute(context=MagicMock())
+ @pytest.mark.parametrize(
+ ("blocks", "expected"),
+ [
+ pytest.param(
+ ("Intro", " ", [["Name", "Qty"], ["Apple", "3"]], "Outro"),
+ "Intro\n\n| Name | Qty |\n| Apple | 3 |\n\nOutro",
+ id="tables-in-document-order",
+ ),
+ pytest.param(([["a", "", "c"]],), "| a | | c |",
id="empty-cell-keeps-its-column"),
+ pytest.param(
+ ([["h1", "h2"], ["", ""], ["x", "y"]],),
+ "| h1 | h2 |\n| x | y |",
+ id="empty-row-skipped",
+ ),
+ pytest.param(
+ ("Before", [["", ""]], "After", [["Name", "Qty"]]),
+ "Before\n\nAfter\n\n| Name | Qty |",
+ id="empty-table-skipped",
+ ),
+ pytest.param(
+ ([["line1\nline2", "b"]],),
+ "| line1 line2 | b |",
+ id="cell-line-break-stays-on-row",
+ ),
+ ],
+ )
+ def test_docx_tables(self, blocks, expected):
Review Comment:
Added that case, and checked that it fails with a text-equality check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
