yuseok89 commented on code in PR #74011:
URL: https://github.com/apache/airflow/pull/74011#discussion_r4171001368
##########
airflow-core/src/airflow/ui/src/hooks/useDateRangeFilter.ts:
##########
@@ -300,6 +286,30 @@ export const useDateRangeFilter = ({ onChange, translate,
value }: UseDateRangeF
});
};
+ const commitEditingState = () => {
+ const { inputs } = editingState;
+
+ if (validateInputs(inputs).length > 0) {
+ return;
+ }
+
+ const nextStartDate = combineDateAndTime(inputs.start, inputs.startTime, {
+ timezone: selectedTimezone,
+ });
Review Comment:
Opening and closing the picker without edits seems to shift the value when
the UI timezone differs from the browser's. With the browser in Asia/Seoul
(UTC+9) and the UI timezone set to UTC, a filter starting at 1:00 AM UTC shows
10:00 AM in the inputs and comes back as 10:00 AM UTC on close. It looks like
the inputs are filled in the browser timezone but read back in
`selectedTimezone` here. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
