fat-catTW commented on code in PR #73464:
URL: https://github.com/apache/airflow/pull/73464#discussion_r4173521357


##########
airflow-core/docs/authoring-and-scheduling/language-sdks/java.rst:
##########
@@ -566,6 +566,36 @@ Edges are checked when the Dag is registered with a 
``Bundle``: an upstream that
 Dag, or to no Dag, and a cycle anywhere in the graph both fail there rather 
than at the first task
 run.
 
+.. _java-sdk/task-state-store:
+
+Task state store
+~~~~~~~~~~~~~~~~
+
+``client.taskStateStore`` gives a task key-value state that is scoped to the 
task instance and survives
+retries and later runs (see :doc:`/core-concepts/task-and-asset-state-store`). 
Use it to remember things

Review Comment:
   Look great to me. Thanks for the PR.
   Just a nit: "later runs" sounds like this persists across later Dag runs, 
but task state store is scoped to one task instance/run. Could we say "retry 
attempts within the same Dag run" instead?



##########
java-sdk/sdk/src/main/kotlin/org/apache/airflow/sdk/Client.kt:
##########
@@ -215,6 +226,63 @@ class Client internal constructor(
   }
 }
 
+/**
+ * Key-value state scoped to one task instance, shared across its retries and
+ * later runs.

Review Comment:
   Here also.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to