AshleyImmanuel commented on PR #74082: URL: https://github.com/apache/airflow/pull/74082#issuecomment-5978334648
Thanks for the review! I've updated the PR based on your feedback: 1. **Reverted to while True** -- the natural NextToken-based pagination termination already handles exit, so the arbitrary 100-page cap was unnecessary and could have prevented finding a legitimate match. 2. **Kept the except Exception -> except ClientError narrowing**, so non-AWS errors (e.g., TypeError, KeyError) won't be silently swallowed. 3. Updated the test to verify that pagination exhausts all pages and returns None when no match is found. --- Drafted-by: Antigravity; reviewed by @AshleyImmanuel before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
