ashb opened a new pull request, #74204: URL: https://github.com/apache/airflow/pull/74204
These handlers previously identified a task's logs by coordinates (dag, task, run, map index, try number). Once a task can run in several loop passes that share those coordinates, the identity has to come from something that is unique per attempt, and with the ownership change every try already has its own UUID. Elasticsearch and OpenSearch entries now carry the task instance's id as ``ti_id`` and Cloud Logging entries carry it as a label of the same name, next to the existing log_id or labels, so the human-readable identity and any Kibana or Logs Explorer, etc. queries built on them continue to work. Readers match on that id alone, or fall back to the log_id or labels for entries that have no ``ti_id``, so logs written before this change stay readable without reindexing. ``ti_id`` is where the task process has bound the UUID in to its own log lines since 3.3, so entries from 3.3 onward already match. Nothing earlier wrote it, and most lines the supervisor logs itself do not carry it either, so the Elasticsearch and OpenSearch uploaders add it to every line they ship. Readers only match on the id from Airflow 3.4. Before then clearing a task instance gives the live row a new id, so it may no longer be the id its logs were written under, and earlier versions keep matching on log_id or labels alone. Downloading every try on Google Cloud Logging drops the id condition just as it already drops the try number. Co-Authored-By: Claude <[email protected]> <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. For user-facing UI changes, please attach before/after screenshots (or a short screen recording) so reviewers can assess the visual impact. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
