pierrejeambrun commented on code in PR #74084: URL: https://github.com/apache/airflow/pull/74084#discussion_r4182434596
########## scripts/ci/prek/dump_yaml_importer_schema.py: ########## Review Comment: Since only [generate_yaml_importer_schema_snapshot.py](https://github.com/apache/airflow/pull/74084/changes#diff-897a19c072eee955595ebd86de0d64e0ff24351d3b41c534a50155a45b5092fe) is called in [.pre-commit-config.yaml](https://github.com/apache/airflow/pull/74084/changes#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9) and [dump_yaml_importer_schema.py](https://github.com/apache/airflow/pull/74084/changes#diff-f2a8a7a606845e1bad3abeab55a639840575713562004f19515a8b5a82a18c1b) is just a 'helper' file for the hook, we can probably inline it directly inside [generate_yaml_importer_schema_snapshot.py](https://github.com/apache/airflow/pull/74084/changes#diff-897a19c072eee955595ebd86de0d64e0ff24351d3b41c534a50155a45b5092fe). (Unless we plan on adding more hook and sharing the dump utility code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
