namanjain24-sudo opened a new pull request, #74242:
URL: https://github.com/apache/airflow/pull/74242

   Dag discovery accepts a packaged Dag whose archive name ends in `.ZIP` 
(`zipfile.is_zipfile()` checks file content, not the extension's case), but 
`ZIP_REGEX` in `airflow-core/src/airflow/utils/file.py` only matched a 
lowercase `.zip` path segment. So `correct_maybe_zipped()` and 
`open_maybe_zipped()` did not treat `archive.ZIP/dag.py` as a path inside an 
archive, and reading the Dag's source back (e.g. `DagCode`) raised 
`NotADirectoryError`.
   
   Match the `.zip` suffix case-insensitively so the read path accepts every 
archive name the discovery path already does.
   
   closes: #74060
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Sonnet 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to