namanjain24-sudo opened a new pull request, #74245: URL: https://github.com/apache/airflow/pull/74245
`shared/observability/src/airflow_shared/observability/metrics/stats.py` has been exempted from the `check-airflow-imports-in-shared` hook since the hook was introduced (#61350). The exemption covered the dynamic `import_module()` calls the unmerged #69270 would have added to let the shared module self-configure by reaching into its consuming distribution's config. #69270 never merged. `main` already fixes the underlying bug (#69172) a different way: each distribution calls `stats.initialize(factory=...)` explicitly at its own entry point (API server startup, task runner subprocess init) instead of the shared module importing core/sdk modules itself. `stats.py` has no `airflow.*` import of any kind today, static or dynamic — the exemption is stale. Verified `check_airflow_imports_in_shared.py` passes on `stats.py` with the exemption removed. closes: #74072 ##### Was generative AI tooling used to co-author this PR? - [X] Yes (please specify the tool below) Generated-by: Claude Code (Sonnet 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
