jingi723 commented on code in PR #74129:
URL: https://github.com/apache/airflow/pull/74129#discussion_r4185171238
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -813,12 +819,15 @@ def _check_success_task(self) -> None:
)
def on_kill(self) -> None:
- if not self.client or not self.arn:
+ if self.stop_task_on_kill and (not self.client or not self.arn):
Review Comment:
Done in 137ebd9973863405605b1323e5b223e5368f14c3. Log-fetcher cleanup now
runs before the client/ARN guard, with regressions for both missing-client and
missing-ARN cases. The related ECS suite passes (117 tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
