subhramit commented on PR #74202: URL: https://github.com/apache/airflow/pull/74202#issuecomment-5996967428
Not a thorough review but the overall direction looks okay to me. Thanks especially for the screenshots. A committer will take a closer look soon. Meanwhile, some pointers - 1. Please go through the project's contributing guidelines. Here, [rebasing is preferred over back-merging](https://github.com/apache/airflow/blob/81b93db4a2f6da3d4e56a337f0f0b84fb2f1b029/contributing-docs/05_pull_requests.rst?plain=1#L109-L112) `main`. 2. (more of a nit) the commit messages are too generic and not helpful. https://cbea.ms/git-commit/ can be a good resource. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
