firasbouzazi commented on PR #74211: URL: https://github.com/apache/airflow/pull/74211#issuecomment-6001320078
> Approving. Moving from `select()` to `selectors.DefaultSelector` fixes the FD_SETSIZE limit without changing the read and shutdown logic, and the in-process server test shows it with real descriptors above 1024. > > One follow-up: `providers/ssh/tunnel.py` (`_serve_forever`) has the same `select()` call. There the `ValueError` is caught and the forwarding thread just exits, so with more than 1024 descriptors open, `SSHHook.get_tunnel()` leaves a local port that accepts connections but never forwards them. Since channels come and go in that loop, it needs register/unregister calls rather than a drop-in swap. Would you be up for a follow-up PR? > > Drafted-by: Claude Code (Opus 5.5); reviewed by @potiuk before posting Sure :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
