ashb commented on code in PR #73116:
URL: https://github.com/apache/airflow/pull/73116#discussion_r4189215480


##########
task-sdk/pyproject.toml:
##########
@@ -53,8 +53,10 @@ dependencies = [
     "asgiref>=3.11.1; python_version >= '3.14'",
     "attrs>=24.2.0, !=25.2.0",
     "babel>=2.17.0",
+    # Direct import in airflow.sdk.api.client; used to arrive via httpx, but 
httpx2 uses truststore.
+    "certifi>=2024.7.4",

Review Comment:
   Sorry if this was discussed already (the perils of resolving conversations) 
why depend on "certifi" -- we don't _strictly_ need certifi do we (and "the 
code uses it today" isn't a reason to keep it), and if httpx2 uses something 
different, is it worth us having two cert trust stores? Why not switch to 
truststore too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to