potiuk commented on code in PR #74155:
URL: https://github.com/apache/airflow/pull/74155#discussion_r4189367651
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/pod.py:
##########
@@ -318,7 +318,7 @@ async def _wait_for_pod_start_within_deadline(self) ->
ContainerState:
)
try:
return await asyncio.wait_for(self._wait_for_pod_start(),
timeout=remaining)
- except asyncio.TimeoutError as exc:
+ except TimeoutError as exc:
Review Comment:
On 3.10, `asyncio.wait_for` raises `asyncio.TimeoutError`, which isn't the
builtin `TimeoutError`, so until layer 7 bumps `requires-python` this would let
the timeout escape instead of becoming `PodLaunchTimeoutException`. That's
harmless on 3.11+. It just needs this layer and layer 7 to ship together, so
'no behaviour change' holds only for 3.11+.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
