kaxil commented on code in PR #68012:
URL: https://github.com/apache/airflow/pull/68012#discussion_r4189459017
##########
task-sdk/src/airflow/sdk/execution_time/schema/schema.json:
##########
@@ -5113,6 +5113,19 @@
"title": "Task Reschedule Count",
"type": "integer"
},
+ "first_task_reschedule_start_date": {
Review Comment:
The Go SDK's vendored copy, `go-sdk/schema/supervisor-schema.json`, didn't
get this field, so Static checks fails on `sync-go-sdk-schemas` and
`check-go-sdk-generated-drift` ([job
log](https://github.com/apache/airflow/actions/runs/37375213623/job/111984946785)).
The drift hook flags `models.gen.go`, `discriminators.gen.go` and
`defaults.gen.go` under `go-sdk/pkg/execution/genmodels/`. To fix it, run `prek
run sync-go-sdk-schemas`, then `(cd go-sdk && just generate-models)`, and
commit the vendored schema with the regenerated files.
##########
task-sdk/src/airflow/sdk/execution_time/schema/versions/v2026_10_30.py:
##########
@@ -64,3 +64,19 @@ class AddDagDefinitionsToDagFileParsingResult(VersionChange):
schema(DagFileParsingResult).field("parsed_definitions").didnt_exist,
schema(DagFileParsingResult).field("dag_source_codes").didnt_exist,
)
+
+
+class AddFirstTaskRescheduleStartDateToSupervisorTIRunContext(VersionChange):
Review Comment:
Could this get a real-bundle downgrade test in `test_migrator.py`, the way
`TestRealBundleArgBindingsDowngrade` and `TestRealBundleRetryReason` cover the
other 2026-10-30 changes? A `didnt_exist`-only change is only visible through
`SchemaVersionMigrator.downgrade`. Right now no test would fail if it were
dropped from `get_bundle()` or registered under the wrong version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
