bingqin2 commented on PR #72954: URL: https://github.com/apache/airflow/pull/72954#issuecomment-6004957104
Thanks for the review, @VladaZakharova. Pushed: reserved names in the extras (`grant_type`, `client_id`, `client_secret`) now get a clear error, values under sensitive key names are masked in task logs, and the field must hold a JSON object. Details are in the threads. Looking at the supplier for your second point, I also found that its token cache key used the extra parameters' names but not their values, so two connections that differ only in `audience` could be handed each other's token within one process. The key now includes the values, with a test that fails on main. The token supplier, credentials provider and base hook tests pass (153). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
