kaxil commented on PR #71477:
URL: https://github.com/apache/airflow/pull/71477#issuecomment-6005879648
Thanks, this looks good to me. A few non-blocking things, fine as a
follow-up or in this PR, your call:
- `_LEADING_LITERAL_NAME_RUN` has no `$` anchor, so "``SandboxToolset``
parameters" gives `SandboxToolset` its only Guide link, a parameter table on
`sandbox/configuration.html`, not the `sandbox/index.rst` guide. Anchoring it
to the end of the title changes only that link at HEAD, or `sandbox/index.rst`
could end its title in ``SandboxToolset``.
- When the registry is built from a ref ahead of a provider's last release
(manual dispatch, or the publish workflow's full-rebuild fallback),
`extract_parameters.py` reads unreleased titles but links `/stable`. Today
that's 8 of common.ai's 32 links, the four retitled pages, which still land at
the top of the right page. Reading the docs at `providers-{id}/{version}` when
the tag exists, via the `read_guide_docs` path `extract_versions.py` already
has, would close it.
- `_extract_class_level_modules` in `test_extract_versions.py` doesn't patch
`read_guide_docs`, so 12 existing tests now shell out to a real `git ls-tree`
and pass because the `CalledProcessError` is swallowed. Patching
`extract_versions.read_guide_docs` (autospec, `return_value={}`) there fixes it.
- `test_skips_generated_and_release_note_pages_before_calling_git_show` no
longer reaches `git_show`; adding a `.png` and `conf.py` path to it would also
pin the `.rst` filter, which nothing covers today.
- Small comment fixes: drop `#73523` and "reviewer-reported" from the tests
and `docs_guides.py`, and the "Mutation canary" narration; the
`git_cat_file_batch` docstring says `git_show` fails loud on
`CalledProcessError`, but it returns None; the `guide_url` comment in
`registry_contract_models.py` leaves out decorator modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
