nuclearpinguin commented on a change in pull request #6998: [AIRFLOW-6404] -
ANSI color support for WebUI logger
URL: https://github.com/apache/airflow/pull/6998#discussion_r365956885
##########
File path: airflow/utils/log/logging_mixin.py
##########
@@ -109,7 +110,10 @@ def _propagate_log(self, message):
"""
Propagate message removing escape codes.
"""
- self.logger.log(self.level, remove_escape_codes(message))
+ if conf.getboolean('core', 'colored_ui_logs'):
+ self.logger.log(self.level, message)
+ else:
+ self.logger.log(self.level, remove_escape_codes(message))
Review comment:
Got it. I am just wondering if colored logs in ui shouldn't be default.
@potiuk @mik-laj WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
