ashb commented on a change in pull request #6870: [AIRFLOW-578] Fix check
return code
URL: https://github.com/apache/airflow/pull/6870#discussion_r365983674
##########
File path: airflow/utils/state.py
##########
@@ -122,3 +122,10 @@ def unfinished(cls):
cls.UP_FOR_RETRY,
cls.UP_FOR_RESCHEDULE
]
+
+ @classmethod
+ def unsuccessful(cls):
+ """
+ A list of states indicating that a task completed unsuccessfully.
+ """
+ return [cls.FAILED, cls.UP_FOR_RETRY, cls.UP_FOR_RESCHEDULE]
Review comment:
Not sure reschedule should be in this list -- it's used by sensors to retry
but not tie up a slot. But this is basically still "running" otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
