kaxil commented on code in PR #70930:
URL: https://github.com/apache/airflow/pull/70930#discussion_r4195183349
##########
providers/snowflake/tests/unit/snowflake/operators/test_snowflake_cortex_agent.py:
##########
@@ -104,3 +108,173 @@ def test_template_fields(self):
"messages",
"snowflake_conn_id",
)
+
+
+class TestSnowflakeCortexAgentCreateOperator:
+ @mock.patch(
+
"airflow.providers.snowflake.operators.snowflake_cortex_agent.SnowflakeCortexAgentHook.create_agent"
Review Comment:
Going further: the `test_template_fields` tests restate the tuple and can't
fail on a real bug, and `check-template-fields-valid` already checks the
mapping, so I'd drop them, including the existing one for the run operator. For
`test_execute`, one autospec'd test per operator with only the required
arguments would cover both the hook signature and the defaults, which the
current all-arguments version can't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
