mik-laj commented on a change in pull request #6998: [AIRFLOW-6404] - ANSI
color support for WebUI logger
URL: https://github.com/apache/airflow/pull/6998#discussion_r366037476
##########
File path: airflow/utils/log/logging_mixin.py
##########
@@ -109,7 +110,10 @@ def _propagate_log(self, message):
"""
Propagate message removing escape codes.
"""
- self.logger.log(self.level, remove_escape_codes(message))
+ if conf.getboolean('core', 'colored_ui_logs'):
+ self.logger.log(self.level, message)
+ else:
+ self.logger.log(self.level, remove_escape_codes(message))
Review comment:
Stackdriver doesn't support colored logs. Many other external task handlers
also. This can also be problematic for other handlers. We'd have to test it
with all the handles to make sure we can turn it on by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
