MohammadHijjawi97 commented on PR #73864: URL: https://github.com/apache/airflow/pull/73864#issuecomment-6011910488
Thanks @potiuk, good catch. Updated in 4ed6e66: when a string parameter is parsed as JSON and gives a dict, keys whose value is `null` are now dropped, so Jenkins uses the parameter default, and booleans are sent as `"true"` / `"false"`. Dict/list parameters and Python-literal strings are passed through unchanged. I chose dropping over rejecting, since leaving the parameter out matches what `null` usually means for a build parameter. Tests: the `json null` case now expects the key to be omitted, the booleans case expects `"true"`/`"false"`, and a new case checks that other JSON values (strings, ints) are unchanged. This also fixes the mypy arg-type error the previous head had on the `literal_eval` call. --- Drafted-by: Claude Code (Claude Opus 5.5) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
