aaron-y-chen opened a new pull request, #74377: URL: https://github.com/apache/airflow/pull/74377
The scheduled canary on `main` ([Tests (ARM) run](https://github.com/apache/airflow/actions/runs/37520137625)) fails deterministically on every core test job and on static checks. This comes from two PRs merged on the same day that conflict without a merge conflict: - #74222 changed `XComModel` into a read projection over both XCom stores. The filters of `XComModel.get_many()` now live inside the aliased entity it selects, and columns added to that statement must be read through `xcom_entity(query)`. The same PR added the `check-xcom-model-columns` hook to enforce this. - #74283 added `_mapped_group_skip_decisions()`, which projects `XComModel.task_id`, `XComModel.map_index` and `XComModel.value` onto the `get_many()` statement. The base `XComModel` columns refer to the unfiltered projection, not the filtered alias. Projecting them with `with_only_columns()` and dropping the ordering removes the alias from the query, so every XCom row is read, whatever its run, Dag or key. A ShortCircuitOperator's boolean `return_value` then counts as a skip decision, and scheduling a task downstream of a short-circuit in a mapped task group fails with `TypeError: argument of type 'bool' is not iterable`. Outside the tests this also means one full XCom read per mapped task group per scheduling pass. Reading the columns through `xcom_entity(query)` keeps the query on the filtered alias, as the other `get_many()` callers already do. --- Error Msg: ```console airflow-core/src/airflow/ti_deps/deps/not_previously_skipped_dep.py:181:37: `XComModel.task_id` is used directly in a SQLAlchemy query; read it through `xcom_entity(query).<column>` instead. airflow-core/src/airflow/ti_deps/deps/not_previously_skipped_dep.py:181:56: `XComModel.map_index` is used directly in a SQLAlchemy query; read it through `xcom_entity(query).<column>` instead. airflow-core/src/airflow/ti_deps/deps/not_previously_skipped_dep.py:181:77: `XComModel.value` is used directly in a SQLAlchemy query; read it through `xcom_entity(query).<column>` instead. ``` --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] Yes (please specify the tool below) Generated-by: [Claude Opus-5.5] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
