vatsrahul1001 commented on PR #74385:
URL: https://github.com/apache/airflow/pull/74385#issuecomment-6032113499

   mypy's red on the new test_capability.py — the union part at line 344 needs 
narrowing, and line 430 overrides a writeable attr with a property. And 
deleting CachingToolset left a stale reference behind: 
run_provider_yaml_files_check.py still has it in 
INTERNAL_UNREGISTERED_TOOLSET_CLASSES, that line can go.
   
   A couple of these are also breaking and should get a note in changelog.rst — 
durable now needs an id on every toolset (DAG won't load otherwise, where 
before an id-less one just ran), and a non-serializable tool result fails the 
task now instead of silently re-running.
   
   The xcom static-check failure isn't yours btw, that's the #74283 thing — fix 
is up in #74390.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to