ccoliu commented on PR #72425: URL: https://github.com/apache/airflow/pull/72425#issuecomment-6033014960
Thanks @bbovenzi and @pierrejeambrun! Updated following the discussion: - **Pending-only:** "Skipped" is offered only for a single task instance with no state, `scheduled`, `up_for_reschedule` or `up_for_retry` (a narrower list than `isStatePending()`, which also includes running/queued/deferred states). It was removed from the task group, Dag run and bulk actions. - **No effect on other TIs:** when marking as skipped, the past/future/upstream/downstream options are disabled and always sent as `false`, even if the user's default options include them. - **Info text** in the modal explaining what skipping does and the trigger-rule pitfall. - **Docs:** added a "Marking a Task Instance as skipped" section to `core-concepts/tasks.rst`. I kept the gate in the UI for now; enforcing it in the PATCH endpoint could be a follow-up PR if you'd like. Verified locally with a Dag mirroring the use case from #72386 (`wait_for_file_b` sensor in reschedule mode → `ingestion_b` → `transformations`, plus `ingestion_a` → `transformations`): | Sensor in `up_for_reschedule` | Already-succeeded task | |---|---| | <img width="1400" height="900" alt="wait_for_file_b_menu" src="https://github.com/user-attachments/assets/08b7325e-2694-49ff-a40a-d9fdf2b328c2"; /> | <img width="1400" height="900" alt="ingestion_a_menu" src="https://github.com/user-attachments/assets/8655b7a3-c672-4747-b82d-6d507e1e35eb"; /> | Mark as skipped dialog: <img width="1400" height="900" alt="wait_for_file_b_dialog" src="https://github.com/user-attachments/assets/df429fe4-8258-47e4-b8b9-4b940293d283"; /> After confirming, `ingestion_b` and `transformations` were skipped via the default `all_success` trigger rule, and the Dag run finished as success: <img width="1400" height="900" alt="after_confirm" src="https://github.com/user-attachments/assets/30572221-c77b-499e-ad44-27c783eef4da"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
