Pushkal-Gupta commented on PR #74027: URL: https://github.com/apache/airflow/pull/74027#issuecomment-6034771517
Thanks for the approval! I had a dig before re-running, and the static check turned out not to be a UI thing at the time. The only hook failing was `check-go-sdk-generated-drift`, on the generated Go models, which came in with the schema change in #73853 and had already been fixed on main by #74028. A re-run wouldn't have picked that up either, which took me a bit to work out. Re-runs reuse the merge commit from the original event, so it would just rebuild the same tree. Our run started about ten hours before #74028 landed, so the fix wasn't there yet whichever way we ran it. Rebasing was the only way in. So: rebased onto main. The go-sdk drift is gone and WebKit passed this time. Static checks is still red, but it's a different hook now and still not from this PR. `ts-compile-lint-ui` reports two `unicorn/prefer-logical-operator-over-ternary` errors in `useAdvancedSearch.ts` and `useRecentTaskStateCounts.tsx`, both of which landed on main yesterday in #74289 and #69619. Neither file is in this diff. I've put a fix up separately in #74402 so it isn't tangled up with the OpenAPI change — one of the two rewrites reads worse than the ternary it replaces, so it could use a UI opinion. This PR itself is green locally on the new base: 0 violations, 36 hook tests passing, mypy clean, and regenerating the specs and UI client produced no diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
