uranusjr commented on code in PR #68517:
URL: https://github.com/apache/airflow/pull/68517#discussion_r4204109926
##########
airflow-core/src/airflow/timetables/assets.py:
##########
@@ -47,8 +47,9 @@ def __init__(
*,
timetable: Timetable,
assets: Collection[SerializedAsset] | SerializedAssetBase,
+ batch_asset_events: bool | None = None,
Review Comment:
Instead of `bool | None`, maybe this class should use attrs or dataclass
factory to keep the argument typed as simply `bool`. This would also remove the
need for coercing None manually inside `__init__` (which can be a bit difficult
to maintain).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
